Clean up RFQ examples: fix typos and remove commented code #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Co-authored-by: 8ball030 <35799987+8ball030@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix types and remove unused code in RFQ module
Clean up RFQ examples: fix typos and remove commented code
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed typos and dead code from RFQ example files following code review feedback.
Changes
efffect→effectin delta hedger commentexpired Better luck→expired. Better luckLegUnpricedSchemaexamples from00_create_rfq.pyFiles Modified
examples/rfqs/00_create_rfq.py- removed commented example legsexamples/rfqs/01_simple_rfq_quoter.py- fixed log message punctuationexamples/rfqs/02_delta_hedged_quoter.py- fixed typo and log message punctuation💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.