Skip to content

Conversation

@8ball030
Copy link
Owner

@8ball030 8ball030 commented Feb 1, 2026

  • chore:removed-dead-code
  • feat:e2e-for-quoting
  • feat:added-rfq-demo
  • feat:added-simple-rfq-quoter
  • feat:added-simple-rfq-quoter
  • chore:codegen
  • feat:ensured-pricing-strategy-makes-a-modicum-off-send
  • feat:ensure-rffq-prices-by-market
  • feat:silly-bug
  • ffeat:silly-typo
  • feat:delta-hedged-quoter-added
  • renamed-rfq
  • feat:first-draft-of-delta-hedger
  • feat:delta-hedging-rfq-added

@8ball030
Copy link
Owner Author

8ball030 commented Feb 1, 2026

@copilot please fix all types and removed the unsed code

Copy link
Contributor

Copilot AI commented Feb 1, 2026

@8ball030 I've opened a new pull request, #200, to work on those changes. Once the pull request is ready, I'll request review from you.

@8ball030
Copy link
Owner Author

8ball030 commented Feb 1, 2026

@copilot there are a few typos, and commented out code, we need to remove them

Copy link
Contributor

Copilot AI commented Feb 1, 2026

@8ball030 I've opened a new pull request, #201, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: 8ball030 <35799987+8ball030@users.noreply.github.com>
@8ball030
Copy link
Owner Author

8ball030 commented Feb 1, 2026

@copilot add a load of comments to the code to explain the intention

Copy link
Contributor

Copilot AI commented Feb 1, 2026

@8ball030 I've opened a new pull request, #202, to work on those changes. Once the pull request is ready, I'll request review from you.

Clean up RFQ examples: fix typos and remove commented code
@8ball030
Copy link
Owner Author

8ball030 commented Feb 1, 2026

@copilot please add comments to the 3 example files and only them to explain the intention of the code

Copy link
Contributor

Copilot AI commented Feb 1, 2026

@8ball030 I've opened a new pull request, #203, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: 8ball030 <35799987+8ball030@users.noreply.github.com>
docs: add comprehensive comments to RFQ example files
@8ball030
Copy link
Owner Author

8ball030 commented Feb 1, 2026

@copilot Please run make fmt lint in the root directory, it will format the examples correctly

Copy link
Contributor

Copilot AI commented Feb 1, 2026

@8ball030 I've opened a new pull request, #204, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits February 1, 2026 05:16
Co-authored-by: 8ball030 <35799987+8ball030@users.noreply.github.com>
@8ball030 8ball030 merged commit 0a1fa90 into main Feb 1, 2026
1 check passed
@8ball030 8ball030 deleted the feat/finishing-rfq-2 branch February 1, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants