Skip to content
This repository was archived by the owner on Jun 5, 2023. It is now read-only.

Dependency auto update #191

Merged
diondiondion merged 4 commits into from
Apr 21, 2022
Merged

Dependency auto update #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e62e374
chore(deps): automerge renovate PR's
Mar 30, 2022
8473bac
chore(release): tidy semantic-release-config
Mar 30, 2022
bff5ab9
Merge branch 'master' into dependency-auto-update
diondiondion Apr 21, 2022
a5ce3ad
chore: Only auto-merge <minor releases, #191
diondiondion Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,21 +114,6 @@
},
"release": {
"branch": "master",
"prepare": [
"@semantic-release/changelog",
{
"path": "@semantic-release/npm",
"pkgRoot": "dist"
},
{
"path": "@semantic-release/git",
"assets": [
"package.json",
"CHANGELOG.md"
],
"message": "chore(release): ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}"
}
],
"plugins": [
[
"@semantic-release/commit-analyzer",
Expand All @@ -142,12 +127,14 @@
}
],
"@semantic-release/release-notes-generator",
"@semantic-release/changelog",
[
"@semantic-release/npm",
{
"pkgRoot": "dist"
}
],
"@semantic-release/git",
"@semantic-release/github"
]
}
Expand Down
3 changes: 2 additions & 1 deletion renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"automerge": false,
"matchUpdateTypes": ["minor", "patch", "pin", "digest"],
"automerge": true,
Copy link
Contributor

@ikhemissi ikhemissi Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test coverage for the project is low (at least in terms of Jest tests) so enabling automerge will just produce more bugs than help us reduce the maintenance of the project.
We can reduce the risk by only automerging non-major changes in the deps, but even that is still very dangerous as we can't check if a new bug in a minor version broke a component or not.
I suggest we work on increasing the coverage of the repo first, and once we are happy with it then we can enable auto merges.

Copy link
Contributor

@diondiondion diondiondion Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong feelings about this, would leave it up to you @MrSwitch and @ikhemissi to decide how to proceed.

I can also live well entirely without dependency auto-updates. ;)

Copy link
Contributor

@diondiondion diondiondion Apr 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ikhemissi, I have now limited auto-updates to non-major changes. There's still a certain risk about minor releases, but updating those deps manually doesn't necessarily make it more likely we'll catch issues with them either. We just need more tests, and those to be more stable, too. At the moment we can't update testing-library/user-events (#195) because this breaks our tests and I can't figure out why. This stuff is the bane of my dev existence. 😅

CC @MrSwitch

"extends": ["config:base", ":preserveSemverRanges"]
}