-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "automerge": false, | |||
| "automerge": true, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test coverage for the project is low (at least in terms of Jest tests) so enabling automerge will just produce more bugs than help us reduce the maintenance of the project.
We can reduce the risk by only automerging non-major changes in the deps, but even that is still very dangerous as we can't check if a new bug in a minor version broke a component or not.
I suggest we work on increasing the coverage of the repo first, and once we are happy with it then we can enable auto merges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong feelings about this, would leave it up to you @MrSwitch and @ikhemissi to decide how to proceed.
I can also live well entirely without dependency auto-updates. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ikhemissi, I have now limited auto-updates to non-major changes. There's still a certain risk about minor releases, but updating those deps manually doesn't necessarily make it more likely we'll catch issues with them either. We just need more tests, and those to be more stable, too. At the moment we can't update testing-library/user-events (#195) because this breaks our tests and I can't figure out why. This stuff is the bane of my dev existence. 😅
CC @MrSwitch
diondiondion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrSwitch I've limited auto-updates to non-major versions, otherwise this is fine with me.
|
🎉 This PR is included in version 14.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Cleans up the semantic-release config, removing unnecessary settings
Reverts Renovate's automate setting back to true...
This is why...