feat: add timeout info to Endblock and set in FinalizeBlockResp#11
Closed
damiannolan wants to merge 9 commits intorelease/v0.50.x-celestiafrom
Closed
feat: add timeout info to Endblock and set in FinalizeBlockResp#11damiannolan wants to merge 9 commits intorelease/v0.50.x-celestiafrom
damiannolan wants to merge 9 commits intorelease/v0.50.x-celestiafrom
Conversation
|
@damiannolan your pull request is missing a changelog! |
damiannolan
commented
Mar 19, 2025
| @@ -1,4 +1,6 @@ | |||
| go 1.21 | |||
| go 1.23 | |||
Author
There was a problem hiding this comment.
It looks like this is causing a lot stuff to explode. I think will probs need to update a lot of files here to get things building.
Do we need go1.23 in the celestia-core fork or was that just updated by happenstance? @tac0turtle
Author
There was a problem hiding this comment.
nvm, looks like celestia-core and their sdk fork are already both using go1.23. think this is something we just have to deal with
This was referenced Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
TimeoutInfotoEndblockto propagate toFinalizeBlockResponseRequires go mod replace to celestia-core
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change