Skip to content

feat: add timeout info to Endblock and set in FinalizeBlockResp#11

Closed
damiannolan wants to merge 9 commits intorelease/v0.50.x-celestiafrom
damian/add-timeout-info-to-endblock
Closed

feat: add timeout info to Endblock and set in FinalizeBlockResp#11
damiannolan wants to merge 9 commits intorelease/v0.50.x-celestiafrom
damian/add-timeout-info-to-endblock

Conversation

@damiannolan
Copy link

Description

Adds TimeoutInfo to Endblock to propagate to FinalizeBlockResponse
Requires go mod replace to celestia-core


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions
Copy link

@damiannolan your pull request is missing a changelog!

Copy link
Author

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy amount of diffs here

@@ -1,4 +1,6 @@
go 1.21
go 1.23
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is causing a lot stuff to explode. I think will probs need to update a lot of files here to get things building.

Do we need go1.23 in the celestia-core fork or was that just updated by happenstance? @tac0turtle

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, looks like celestia-core and their sdk fork are already both using go1.23. think this is something we just have to deal with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants