chore: update to go1.23 in prep for celestia-core fork replace#431
Merged
damiannolan merged 4 commits intocelestiaorg:release/v0.50.x-celestiafrom Mar 25, 2025
Merged
Conversation
Collaborator
Author
|
Needs changelog pending reviews |
19 tasks
rootulp
approved these changes
Mar 24, 2025
Collaborator
Author
|
Noticed linting is failing here and was in the original PR. Opened #434 |
Collaborator
|
Removed golangci-lint required check so this can merge after it gets another approval. Can fix golangci-lint in a follow-up PR |
julienrbrt
approved these changes
Mar 25, 2025
damiannolan
merged commit 7133aeb
into
celestiaorg:release/v0.50.x-celestia
42 of 46 checks passed
tac0turtle
pushed a commit
to 01builders/cosmos-sdk
that referenced
this pull request
Apr 7, 2025
…tiaorg#431) * chore: go1.23 everywhere * chore: use go1.23 * chore: use go-version-file in workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to use a go mod replace to pin to the celestia-core fork in order to pick up some changes.
Most notably for CIP26 (adding
TimeoutInfoto abci responses for versioned timeouts).Requires a bump to go1.23.
This is a pre-cursor to that go mod replace pin and implementing the changes to propagate
TimeoutInfothroughsdk.EndBlocktoabci.FinalizeBlockResponse.See 01builders#11
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change