Skip to content

Fix/whiteboard update #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzzevaka merged 2 commits into from
Jan 20, 2026
Merged

Fix/whiteboard update #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2925ef6
Simplify document saving logic
zzzevaka Jan 20, 2026
8b63044
Keep fighting with saving
zzzevaka Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions frontend/src/components/documents/DocumentEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import ExcalidrawEditor, { generateExcalidrawImageBase64 } from '@/components/ed

export default function DocumentEditor({ document, onDocumentUpdate, onFetchContent }) {
const [content, setContent] = useState(null);
const [saveStatus, setSaveStatus] = useState('saved');
const [changeCounter, setChangeCounter] = useState(document.type == "markdown" ? -1 : -3);
const [isLoadingContent, setIsLoadingContent] = useState(false);
const saveTimeoutRef = useRef(null);
Expand All @@ -34,11 +33,9 @@ export default function DocumentEditor({ document, onDocumentUpdate, onFetchCont
const handleChange = useCallback((data) => {
setChangeCounter(prev => prev + 1);
setContent(data);
setSaveStatus('unsaved');
}, []);

const performSave = useCallback(async () => {
setSaveStatus('saving');
try {
let contentToSave;

Expand All @@ -60,20 +57,17 @@ export default function DocumentEditor({ document, onDocumentUpdate, onFetchCont
{ withCredentials: true }
);

setSaveStatus('saved');

if (onDocumentUpdate) {
onDocumentUpdate(document.id, { content: contentToSave });
}
} catch (error) {
console.error("Error saving document:", error);
setSaveStatus('unsaved');
toast.error(`Failed to save document: ${error.response?.data?.detail || error.message}`);
}
}, [content, document.project_id, document.id, onDocumentUpdate]);

useEffect(() => {
if (changeCounter > 0 && saveStatus === 'unsaved') {
if (changeCounter > 0) {
if (saveTimeoutRef.current) {
clearTimeout(saveTimeoutRef.current);
}
Expand All @@ -88,7 +82,7 @@ export default function DocumentEditor({ document, onDocumentUpdate, onFetchCont
clearTimeout(saveTimeoutRef.current);
}
};
}, [changeCounter, performSave, saveStatus]);
}, [changeCounter, performSave]);

const excalidrawInitialData = useMemo(() => {
if (!document.content) return null;
Expand Down Expand Up @@ -130,16 +124,6 @@ export default function DocumentEditor({ document, onDocumentUpdate, onFetchCont
/>
)
}

{/* Save status indicator - only show when not saved */}
{(changeCounter > 0 && saveStatus !== 'saved') && (
<div
className={`fixed bottom-${saveIconBottomOffset} right-4 opacity-70 z-40 backdrop-blur-sm rounded-md shadow-md`}
title={saveStatus === 'saving' ? 'Saving...' : 'Unsaved changes'}
>
<Save className="w-5 h-5 text-primary" />
</div>
)}
</div>
)
}
5 changes: 0 additions & 5 deletions frontend/src/components/editors/ExcalidrawEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ export async function generateExcalidrawImageBase64(excalidrawData, options = {}
}),
});

// Convert blob to base64
return new Promise((resolve, reject) => {
const reader = new FileReader();
reader.onloadend = () => {
Expand Down Expand Up @@ -93,10 +92,6 @@ export default function ExcalidrawEditor({ initialData, onChange, readOnly }) {
return null;
}

if (!data) {
return null;
}

return (
<div className="w-full h-full">
<Suspense fallback={
Expand Down
Loading