Support remaining Agents of S.H.I.E.L.D. cards#300
Merged
Kamalisk merged 1 commit intozzorba:masterfrom Mar 30, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the remaining Agents of S.H.I.E.L.D. cards that are getting added on zzorba/marvelsdb-json-data#608. There are new Evidence card types that are part of this box that needed import functions. Those cards only use text at the moment which is a default import so the functions are blank for now.
This box also added icons in card names for cards 50184a, 50184b, and 50184c ([energy], [mental], and [physical] icons). I tried running the
replaceSymbolsfunction on the card name property but because it always appears in an anchor tag, the raw<span class="icon-energy" />appears. Not sure if there's going to be a way to make that more accurate or not. For the time being, the placeholder text for the icons appear in the card name.