#810 Fixed issue with IO pusher not using max#828
Open
rlking1985 wants to merge 1 commit intozymex22:masterfrom
Open
#810 Fixed issue with IO pusher not using max#828rlking1985 wants to merge 1 commit intozymex22:masterfrom
rlking1985 wants to merge 1 commit intozymex22:masterfrom
Conversation
Sn1p3rr3c0n
reviewed
Jan 5, 2025
| //Transfre a item back if it is either too few or disallowed | ||
| if (currentItem != null && (!settings.AllowedToAccept(currentItem) || !OutputSettings.SatisfiesMin(currentItem.stackCount)) && boundStorageUnit.GetSettings.AllowedToAccept(currentItem)) | ||
| // Transfer a item back if it is either too few or disallowed | ||
| if (currentItem != null && !OutputSettings.useMax && (!settings.AllowedToAccept(currentItem) || !OutputSettings.SatisfiesMin(currentItem.stackCount)) && boundStorageUnit.GetSettings.AllowedToAccept(currentItem)) |
Collaborator
There was a problem hiding this comment.
This looks like it would break the min condition if you use the max condition.
Sn1p3rr3c0n
requested changes
Jan 8, 2025
Collaborator
There was a problem hiding this comment.
While this change fixes the issue outlined in #828 it introduces a new issue.
That would need to be resolved before merging.
Attached is a sample Save File
The IO Port and IO Pusher are configured in the same way:
- Minimum 10
- Maximum 20
- Allowed items: Steel
By activating the lower puller you can move one item at a time.
You can then observe that once the count dips below 10:
- The IO Port correctly -> no longer outputs anything
- The IO Pusher outputs less then the minimum
the IO Ports seem to take a completely separate codepath. maybe some refactoring is in order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added OutputSettings.useMax as a condition when transferring items which seems to fix the issue for the IO pusher (see video demo).
io-pusher-max-demo.mp4