Skip to content

fix: elided lifetime should not be hidden elsewhere#186

Open
dlyongemallo wants to merge 1 commit intozxcalc:masterfrom
dlyongemallo:elided_lifetime_explicit
Open

fix: elided lifetime should not be hidden elsewhere#186
dlyongemallo wants to merge 1 commit intozxcalc:masterfrom
dlyongemallo:elided_lifetime_explicit

Conversation

@dlyongemallo
Copy link

No description provided.

Copilot AI review requested due to automatic review settings November 9, 2025 08:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds explicit lifetime parameters to function return types that return borrowed data structures, improving code clarity and following Rust best practices for explicit lifetime annotations.

  • Adds explicit '_ lifetime parameters to ArrayViewMut return types in tensor operations
  • Adds explicit '_ lifetime parameters to iterator return types in Parity and Expr
  • Adds explicit '_ lifetime parameter to Extractor return type in the ToCircuit trait

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
quizx/src/tensor.rs Adds explicit lifetime annotations to ArrayViewMut return types in slice_qubit_mut trait method and implementation
quizx/src/params.rs Adds explicit lifetime annotations to iterator return types in Parity::iter() and Expr::iter() methods
quizx/src/extract.rs Adds explicit lifetime annotation to Extractor return type in ToCircuit::extractor() method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant