fix: elided lifetime should not be hidden elsewhere#186
Open
dlyongemallo wants to merge 1 commit intozxcalc:masterfrom
Open
fix: elided lifetime should not be hidden elsewhere#186dlyongemallo wants to merge 1 commit intozxcalc:masterfrom
dlyongemallo wants to merge 1 commit intozxcalc:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit lifetime parameters to function return types that return borrowed data structures, improving code clarity and following Rust best practices for explicit lifetime annotations.
- Adds explicit
'_lifetime parameters toArrayViewMutreturn types in tensor operations - Adds explicit
'_lifetime parameters to iterator return types inParityandExpr - Adds explicit
'_lifetime parameter toExtractorreturn type in theToCircuittrait
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| quizx/src/tensor.rs | Adds explicit lifetime annotations to ArrayViewMut return types in slice_qubit_mut trait method and implementation |
| quizx/src/params.rs | Adds explicit lifetime annotations to iterator return types in Parity::iter() and Expr::iter() methods |
| quizx/src/extract.rs | Adds explicit lifetime annotation to Extractor return type in ToCircuit::extractor() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.