This repository was archived by the owner on Sep 10, 2019. It is now read-only.
Remove fixed 1rem spacings on grid CSS. #815
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some spacing amounts were hardcoded to 1rem, making customization through `$block-padding` not work as expected. By using `$block-padding` in all instances, it guarantees spacing consistency. Fixes zurb#669
soumak77
added a commit
to base-apps/angular-base-apps
that referenced
this pull request
Jul 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some spacing amounts were hardcoded to 1rem, making customization through
$block-paddingnot work as expected.By using
$block-paddingin all instances, it guarantees spacing consistency.Fixes #669