Skip to content

feat: add keyboard shortcuts and inline rename functionality to EntitySidebar#49

Merged
zuhanit merged 2 commits intomasterfrom
feat/entity-sidebar-keyboard-shortcuts
Jun 22, 2025
Merged

feat: add keyboard shortcuts and inline rename functionality to EntitySidebar#49
zuhanit merged 2 commits intomasterfrom
feat/entity-sidebar-keyboard-shortcuts

Conversation

@zuhanit
Copy link
Copy Markdown
Owner

@zuhanit zuhanit commented Jun 22, 2025

Summary

  • Implement AssetNode type system with recursive children structure for better tree management
  • Add comprehensive keyboard shortcuts (Delete, F2, R) for entity operations
  • Enable inline rename functionality with SidebarInput integration
  • Support recursive deletion of entities with their children

Test plan

  • Verify Delete key recursively removes selected entities and their children
  • Test F2 and R keys activate inline rename mode for focused entities
  • Confirm Enter saves rename changes and Escape cancels
  • Check that folder selection properly includes all children
  • Validate proper focus management and keyboard navigation

Technical Changes

Type System

  • Added AssetNode<T> type extending Asset<T> with recursive children
  • Updated all asset tree hooks to return proper AssetNode structure
  • Modified entity store to use AssetNode for better type safety

Keyboard Functionality

  • Delete key: Recursive entity deletion including children
  • F2/R keys: Activate inline rename mode
  • Enter: Save rename changes
  • Escape: Cancel rename operation
  • Proper event propagation control

🤖 Generated with Claude Code

zuhanit and others added 2 commits June 22, 2025 16:01
- Add AssetNode type extending Asset with children property
- Update useAssetTree hooks to return proper AssetNode structure
- Modify entityStore to use AssetNode instead of Asset
- Add updateEntityAssetName function to mapStore for rename functionality

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
…ySidebar

- Add Delete key support for recursive entity deletion
- Implement F2 and R key shortcuts for inline rename mode
- Add SidebarInput integration for seamless rename experience
- Support Enter to save, Escape to cancel rename operations
- Include proper event handling and focus management

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@zuhanit zuhanit merged commit f082c9f into master Jun 22, 2025
3 checks passed
@zuhanit zuhanit deleted the feat/entity-sidebar-keyboard-shortcuts branch March 28, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant