Open
Conversation
Owner
|
Hi @juhgiyo, Wow! thanks for your PR, I'm really interested in merging it 😃 But I think it would be good to improve some issues before:
It's OK if you do not have time for this now. I'll leave this PR open whatever time it takes. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for providing such a great module.
While I was trying to use your module for Weblogic Server MBeans with JMX using t3 protocol, I fount that it must use different protocolProvider, and some of libraries from Oracle.
I'm not sure if this change is against your philosophy, but I decided to do a pull request for the reference to someone, who might have same problem as me.
Again, thanks a lot for providing a great module.