This repository was archived by the owner on Dec 18, 2022. It is now read-only.
Origin/feature/49 multipart#125
Open
pocketmun1216 wants to merge 46 commits intoztkmkoo:developfrom
pocketmun1216:origin/feature/49_multipart
Open
Origin/feature/49 multipart#125pocketmun1216 wants to merge 46 commits intoztkmkoo:developfrom pocketmun1216:origin/feature/49_multipart
pocketmun1216 wants to merge 46 commits intoztkmkoo:developfrom
pocketmun1216:origin/feature/49_multipart
Conversation
added 4 commits
August 17, 2020 01:08
Owner
|
PR 감사합니다. 우선 conflict 해결 및 IDE 파일 .iml은 제거 해주시면 감사하겠습니다. |
Alencion
reviewed
Sep 4, 2020
dss-core/src/main/java/io/github/ztkmkoo/dss/core/network/rest/handler/DssRestHandler.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/github/ztkmkoo/dss/core/actor/rest/service/DssRestActorFormDataService.java
Outdated
Show resolved
Hide resolved
RulLu16
reviewed
Sep 4, 2020
RulLu16
reviewed
Sep 4, 2020
Comment on lines
+15
to
+22
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.github.ztkmkoo</groupId> | ||
| <artifactId>dss-server</artifactId> | ||
| <version>0.4.4</version> | ||
| <scope>compile</scope> | ||
| </dependency> | ||
| </dependencies> |
Collaborator
There was a problem hiding this comment.
이미 이전 dss-example/pom.xml에서 dss-server에 대한 dependency가 있기 때문에 굳이 바꿀 이유가 없어보입니다.
Owner
@MunSeongUk |
added 13 commits
September 6, 2020 20:34
reset 후 iml 제거 및 dss-example 삭제
…eongUk/dss into origin/feature/49_multipart
This reverts commit 44f7104.
This reverts commit b3e11cd.
added 5 commits
September 10, 2020 21:21
하지만 현재 에러 발생
This reverts commit c6f7e1d.
…into origin/feature/49_multipart
…eongUk/dss into origin/feature/49_multipart
Doyuni
reviewed
Sep 15, 2020
|
|
||
| @Test | ||
| void constructor3() { | ||
| public void constructor3() { |
Collaborator
There was a problem hiding this comment.
It seems to be better to remove access modifier public.
Doyuni
suggested changes
Sep 15, 2020
Collaborator
Doyuni
left a comment
Doyuni
left a comment
There was a problem hiding this comment.
Hi, good job about handling multipart.
But It needs to be fetched from upstream and seems to be better to remove public access modifier in test code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multipart 처리할 수 있게 하였습니다.
리뷰하실 때
테스팅 코드
DssRestServerTest <- 테스팅 코드 추가
Header 파싱 방법 제안
DssRestRequest <- header의 charset과 boundary 파싱하는 코드를 추가하였습니다.
Body 파싱 방법 제안
DssRestActorFormDataService <- body 부분의 boundary 기준으로 파싱하는 코드를 추가하였습니다.
DssRestActorService
기존 DssRestServiceResponse handling(String content) -> DssRestServiceResponse handling(DssRestServiceActorCommandRequest commandRequest)
로 변경되었습니다. 인터페이스가 변경됨에 따라 인터페이스를 구현하는 하위 클래스 또한 모두 변경되었습니다.
변경 한 이유는
DssRestActorFormDataService <- 해당 클래스에서 content 파싱시 formdata형식은 boundary로 파싱해야 하는데
기존에 content만 넘길 경우 boundary를 넘겨받기가 어렵기 때문에 헤더정보를 같이 넘겨주는 DssRestServiceActorCommandRequest 로 변경하였습니다.
실행 예제
포스트맨으로 테스팅 해보고 싶은 분들은 MultiPart 클래스 <- 참고하시면 됩니다.