feat: add support for Python 3.13 and Django 5.2

[bartvanandel]

Fixes #80

[bartvanandel]

Note: according to the official Django download page, 5.2 will be the last version in the 5.x series. So the version constraint uses this logic.

Many other packages don't even restrict Django versions, they may give a lower limit to the version number, but no upper limit. But provided that PRs like this one can be picked up quickly, more strict version limits may be safer (plus, there's that DJANGO_CURRENTUSER_USE_UNSUPPORTED_DJANGO environment variable).

[zsoldosp]

@bartvanandel thank you! The PR is almost perfect, and on your first attempt! kudos & much appreciated!

One thing missing was that as per https://www.djangoproject.com/download/#supported-versions, 5.0 is not supported anymore asof April (though confusing, as https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django still lists it). This would suggest to change the version number to 0.9.0 rather to indicate this change.

The other missing update is due to adding support python3.13, which would require the CI build to be updated .github/workflows/tox.yml would also need the python 3.13 entry

Can you make those changes or should I do those? I'm happy to do it either way

[bartvanandel]

@bartvanandel thank you! The PR is almost perfect, and on your first attempt! kudos & much appreciated!

Thanks! I've been around for some time, good thing that it's paying off 😃

And thank you for your quick reply!

One thing missing was that as per https://www.djangoproject.com/download/#supported-versions, 5.0 is not supported anymore asof April (though confusing, as https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django still lists it). This would suggest to change the version number to 0.9.0 rather to indicate this change.

Not really. The fact that Django support stopped for 5.0 doesn't mean that it's a breaking change for django-currentuser. This is just a backward-compatible metadata patch, no code was even changed. See also semver. But if you think 0.9.0 is more appropriate, I can change it of course.

The other missing update is due to adding support python3.13, which would require the CI build to be updated .github/workflows/tox.yml would also need the python 3.13 entry

Ah, missed that one. I've updated the PR.

[zsoldosp]

One thing missing was that [...] 5.0 is not supported anymore asof April [...]

Not really. The fact that Django support stopped for 5.0 doesn't mean that it's a breaking change for django-currentuser. Nothing was removed (definitely no breaking changes), nothing major was even added, everything is still compatible with older versions, so a small increase should be fine.

I'd consider this change just a patch, not even a minor update, no code was even changed, just metadata. See also semver. But if you think 0.9.0 is more appropriate, I can change it of course.

I understand your reasoning, and I've been of a similar mindset in the past - why not support something that works with no extra effort. Theoretically, this code still might run with python 2.7... However, when something breaks, do I remove it only then? And if/when people complain why support was removed? Given that Django has a lifecycle, and it's a Django plugin, I just chose to follow the main project's lead, that way there is no confusion. And while I have worked on unsupported legacy code version projects in the past, DJANGO_CURRENTUSER_USE_UNSUPPORTED_DJANGO adequately supports that scenario so if someone needs to, they can run it with 5.0.

So django 5.0 support should be dropped, and as it's pre 1.0 (though probably should bump it to 1.0 at some point, as the code hasn't changed) and that's how prior drops for versions were versioned

But I'm happy to merge it as is, and change the version/support matrix in a following PR (won't be able to release it today anyway)

The other missing update is due to adding support python3.13, which would require the CI build to be updated .github/workflows/tox.yml would also need the python 3.13 entry

Ah, missed that one. I've updated the PR.

thanks!

[bartvanandel]

I'll patch it, it's fine. People can stick with the current version anyway.

I'll remove Python 3.8 from the matrix as well then, since it went EOL six months ago. Nice and clean.

[bartvanandel]

@zsoldosp Done.

I have another commit ready which updates all dev dependencies to their latest versions, including setuptools, tox and docutils, cleaning up tox.ini a bit more in the process. I can either add it to this PR (though somewhat unrelated), or create a new PR after this one has been merged, whichever you prefer.

[zsoldosp]

Please make that a separate PR. I'll merge and release this tomorrow

…

On Mon, Apr 7, 2025, 2:59 PM Bart van Andel ***@***.***> wrote: @zsoldosp <https://github.com/zsoldosp> Done. I have another commit ready which updates all dev dependencies to their latest versions, including setuptools, tox and docutils, cleaning up tox.ini a bit more in the process. I can either add it to this PR (though somewhat unrelated), or create a new PR after this one has been merged, whichever you prefer. — Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAP3WYBQRQ7EGVKCUOTDHD2YJZDDAVCNFSM6AAAAAB2THASGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBTGI2TMMJZGU> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: bartvanandel]*bartvanandel* left a comment (zsoldosp/django-currentuser#81) <#81 (comment)> @zsoldosp <https://github.com/zsoldosp> Done. I have another commit ready which updates all dev dependencies to their latest versions, including setuptools, tox and docutils, cleaning up tox.ini a bit more in the process. I can either add it to this PR (though somewhat unrelated), or create a new PR after this one has been merged, whichever you prefer. — Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAP3WYBQRQ7EGVKCUOTDHD2YJZDDAVCNFSM6AAAAAB2THASGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBTGI2TMMJZGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[zsoldosp]

released to pypi