Speed up builds #181
Open
Speed up builds #181
+143
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build:zoterocommand. Instead of building all the configs, including dev-only ones, it just builds pdf.js and thezoteroconfig. Brings build time down from 0:56 to 0:35.genericandminifiedconfigs instead ofgeneric-legacyandminified-legacy. I believe this is fine now that our Firefox version is relatively up to date, but @mrtcode, let me know if that's not the case. Brings build time down to 0:27.Once this is merged and the submodule is updated in zotero/zotero, we can adjust the build script there to call
npm run build:zoterofor a pretty significant speed boost.Any further optimization would need to happen within the pdf.js build process, which accounts for something like 16 of the remaining 20 seconds of build time.