fix one letter search pop-up behaviour #174
Open
+16
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR fixes the bug described here: zotero/zotero#4972
The bug: when the search field contains one character, the "enter" button does not trigger a new search. Moreover, if the field value was obtained as a result of letter deletion (for example, the first search was 'tr', the second search was: 't'), the search is performed on the old value ('tr').
The bug is expalined by the debouncing behaviour, and how the seach keyword is passed to the search engine. The solution is: whenever a key combination is triggered, we must distinguish two situations
enterorshift+enterfindNextorfindPreviousVisual testing:
reader-before-fix-shrink.mp4
reader-after-fix-shrink.mp4