Skip to content

Release 8.1#131

Merged
icemac merged 2 commits intozopefoundation:masterfrom
cjwatson:release-8.1
Oct 27, 2025
Merged

Release 8.1#131
icemac merged 2 commits intozopefoundation:masterfrom
cjwatson:release-8.1

Conversation

@cjwatson
Copy link
Contributor

  • I signed and returned the Zope Contributor Agreement, and received and accepted an invitation to join a team in the zopefoundation GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Developer guidelines.
  • I included a change log entry in my commits.

It's been a while since I released a Zope package, but I wanted to get the setuptools dependency removal out, so I ran fullrelease on it and then got a "Protected branch update failed" message near the end. Not sure if I did something wrong ...

@icemac icemac merged commit 7c6c2c1 into zopefoundation:master Oct 27, 2025
10 checks passed
@icemac
Copy link
Member

icemac commented Oct 27, 2025

@cjwatson You did everything right: Only very few people are allowed to push directly to master but many people are allowed to release. We did not find a solution yet besides this release PR afterwards.

@cjwatson cjwatson deleted the release-8.1 branch October 27, 2025 16:25
@cjwatson
Copy link
Contributor Author

The downside is that the tag has been left orphaned (not corresponding to anything on master). I guess I should have been more careful to mark this PR as "must not be squashed" somehow. Not the end of the world but a little confusing.

@icemac
Copy link
Member

icemac commented Oct 28, 2025

Right, I nowaday ususally squash merge without thinking but this could have been a normal merge. Maybe I'll keep this in mind for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants