Remove obsolete setuptools runtime dependency#130
Merged
icemac merged 1 commit intozopefoundation:masterfrom Sep 15, 2025
Merged
Remove obsolete setuptools runtime dependency#130icemac merged 1 commit intozopefoundation:masterfrom
setuptools runtime dependency#130icemac merged 1 commit intozopefoundation:masterfrom
Conversation
The runtime dependency on `setuptools` was only required for namespace support. Since `pkg_resources`-style namespaces have been removed in zopefoundation#52 and there are no relevant imports left in the code, remove the unnecessary dependency. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Contributor
Author
|
@icemac, I see the same problem applies to other packages released yesterday. Should I open separate PRs for all of them, or could you perhaps handle it en masse? |
icemac
approved these changes
Sep 15, 2025
Member
|
@mgorny Thank you for the PR. My idea was to solve this issue more generally via zopefoundation/meta#345 – but it can take some time until I'll be able to tackle it. So I'd appreciate individual PRs for the repositories where the |
Contributor
Author
|
Thanks, I'll do that when I have some time. |
8 tasks
Contributor
|
@mgorny I've filed a bunch of individual PRs for this, but just for |
Contributor
Author
|
Thanks! I'm sorry for not being able to look at it sooner. |
Contributor
Author
|
Okay, I've filed PRs for the two extra packages that we had, and that should cover them all. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime dependency on
setuptoolswas only required for namespace support. Sincepkg_resources-style namespaces have been removed in #52 and there are no relevant imports left in the code, remove the unnecessary dependency.