General updates -- Node as module, update depency versionsto supported ones, PHP strict_types declaration and phpunit tests#5
Open
mreiden wants to merge 8 commits intozoonru:zoonfrom
Open
Conversation
mreiden
commented
Aug 19, 2024
mreiden
commented
- Change node-process to module syntax and .mjs
- Add php strict_types declaration
- Get phpunit tests to run
- Update dependency requirements to supported versions
- Add .editorconfig, .gitattributes, and .prettierrc.json5
- Run prettier on source
…orts in ImplementationTest.php
Member
|
Hi, @mreiden! Thanks for the contribution. I missed that pull request. Will look into it soon. Sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.