Open
Conversation
Owner
|
Thanks for working on this @jforberg. I'm going to mirror what I said in #36 with that I agree this functionality should become part of obsidian-export, but doubt that it's necessary to implement this in the core parsing logic though. Think you could try moving this into a postprocessing function instead? |
In addition to normal HTML comment style, Obsidian supports comments enclosed by "%%".
Author
|
@zoni I have rewritten the patch to use a postprocessor instead. I also changed so that Obsidian-style comments are translated into normal markdown/HTML comments, this means they could be used for something later if needed. |
jforberg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These comments are not part of the document proper and it's tricky when they contain other markup.
A future improvement could be to translate these into HTML comments in the output.