Conversation
|
I've just worked out that this approach doesn't work with the tag filtering options, I will try fix this now. |
Make `linked_attachments_only` option compatible with tag filtering, i.e. only occur after post-processing.
zoni
left a comment
There was a problem hiding this comment.
Thank you so much for working on this. I've yet to do a more thorough review of the code, but at a glance, I think this looks alright, so I'm favorable towards accepting it 😄
However, I would like to see some tests being included to validate the intended behavior (including the interaction with tag filtering options) and guard against future regressions as outlined in Contributing > Tests.
Would you mind wiring up some test cases? I'll be happy to provide some additional pointers if needed.
|
Sure, I'll be able to write some tests in a few days. By the way, the way it's currently implemented, any attachments detected during markdown parsing are added to a |
Adds support for #217 via a
--linked-attachments-onlyflag. When enabled, any non-markdown files will only be included if they are linked or embedded within a markdown file.