Skip to content

Conversation

@tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Dec 9, 2025

Purpose

This PR updates DNSSEC05 message IDs as specified in zonemaster/zonemaster#1448.

Context

zonemaster/zonemaster#1448

Changes

  • Message IDs

How to test this PR

  1. Unit tests should still pass.
  2. Check that the updates match the ones in Update DNSSEC05 message IDs zonemaster#1448.
  3. Run DNSSEC05 on a signed zone and check the output, e.g. with zonemaster-cli:
$ zonemaster-cli --show-testcase --level INFO --test dnssec05 --no-ipv6 afnic.fr

Seconds Level    Testcase       Message
======= ======== ============== =======
   0.00 INFO     Unspecified    Using version v8.0.0 of the Zonemaster engine.
  12.80 INFO     DNSSEC05       The DNSKEY with tag 54074 uses algorithm number 13 ("ECDSA Curve P-256 with SHA-256", ECDSAP256SHA256). Fetched from name servers "g.ext.nic.fr/194.0.36.1;ns1.nic.fr/192.134.4.1;ns2.nic.fr/192.93.0.4;ns3.nic.fr/192.134.0.49".
  12.80 INFO     DNSSEC05       The DNSKEY with tag 32674 uses algorithm number 13 ("ECDSA Curve P-256 with SHA-256", ECDSAP256SHA256). Fetched from name servers "g.ext.nic.fr/194.0.36.1;ns1.nic.fr/192.134.4.1;ns2.nic.fr/192.93.0.4;ns3.nic.fr/192.134.0.49".

@tgreenx tgreenx added this to the v2025.2 milestone Dec 9, 2025
@tgreenx tgreenx added A-TestCase Area: Test case specification or implementation of test case V-Patch Versioning: The change gives an update of patch in version. RC-None Release category: Not to be included in Changes file. labels Dec 9, 2025
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is too late in the cycle. The original version is not wrong. But now that the specification has been updated I accept it.

@tgreenx tgreenx merged commit 2d51eef into zonemaster:develop Dec 9, 2025
3 checks passed
@tgreenx tgreenx deleted the update-dnssec05-msg branch December 9, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-TestCase Area: Test case specification or implementation of test case RC-None Release category: Not to be included in Changes file. V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants