Ensure EF Core async methods (EntityFrameworkQueryableExtensions) are properly translated to their synchronous versions #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both in the unit tests and in the sandbox tests
Since there's no way to guess where the sync version of the `EntityFrameworkQueryableExtensions` methods is coming from, hardcode the source (i.e. `System.Linq.Queryable`) just like it was done for `AsyncEnumerable` → `System.Linq.Enumerable`.
0xced
force-pushed
the
EntityFrameworkQueryableExtensions
branch
from
5fe7ea0 to
54a176f
Compare
virzak
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this pull request:
❌ Generated synchronous codes produces a compilation error
After this pull request:
✅ The synchronous methods are properly called on
System.Linq.Queryablewhere they belong.Fixes #107