Better exception message #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 17, 2019 13:56
When writing tokens ensure encoding matches the tokens we are writing Bump gemfil
Ruby Exception has a message method which can be filled with useful info. This info is used by things like Exception Notifier Gem. Populate the message with all the other details being stored in the exception, as described here: https://stackoverflow.com/questions/16106645/ruby-custom-error-classes-inheritance-of-the-message-attribute
WaKeMaTTa
suggested changes
Jan 24, 2020
WaKeMaTTa
left a comment
WaKeMaTTa
left a comment
There was a problem hiding this comment.
Split this Pull Request in 2.
- One should be "Better execption message"
- and the other one should be "Bump dependecy gem: json".
Last thing you should not Bump the version ZCRMSDK. That should be maintained by the maintainers one they merge your PR.
Author
|
Hey @WaKeMaTTa thanks for the suggestions.
|
Author
|
@pravesh-a - wondering if you have had a chance to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for improving the message.