fix(invoice): correctly parse assignment_name in RgbInvoice::from_str#2
Open
astral-bitlight wants to merge 1 commit intozoedberg:0.11.1-2from
Open
fix(invoice): correctly parse assignment_name in RgbInvoice::from_str#2astral-bitlight wants to merge 1 commit intozoedberg:0.11.1-2from
astral-bitlight wants to merge 1 commit intozoedberg:0.11.1-2from
Conversation
astral-bitlight
force-pushed
the
fix/assignname
branch
from
da5b58b to
d400084
Compare
astral-bitlight
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a (seems like?) bug in the parsing logic for
RgbInvoicestrings where the optionalassignment_namefield was not correctly handled during deserialization, leading to data loss during round-trip serialization/deserialization.Updates
The
impl FromStr for RgbInvoicehas been updated to correctly handle both possible path structures:contract/schema/assignment_data(whereassignment_nameisNone)contract/schema/assignment_name/assignment_data(whereassignment_nameisSome(...))Testing
parse_with_assignment_name, has been added to specifically test the round-trip serialization and deserialization of anRgbInvoicecontaining anassignment_name. (This test now passes, confirming the fix. )