Open
Conversation
…hat zcash can interact with nicer. This is obviously only a step in the right direction.
ebfull
force-pushed
the
zc.latest.0.ticketXXX-various-calgary-changes.0
branch
from
8acf563 to
dd5db58
Compare
|
Let's clean up some of this stuff before landing it (which also means bumping the distro in https://github.com/Electric-Coin-Company/zcash/pull/590 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The calgary design implementation requires a few changes to increase code quality on zcash's side or implement important features.
I expect once we land a working and tested implementation, we can clean up a lot of these routines which are needless and messy abstractions. (PourTransaction in particular is a nightmare and probably can be completely replaced by PourProver eventually.) Most of the changes in this PR will act as temporary shims to assist in making those improvements in the future.