-
Notifications
You must be signed in to change notification settings - Fork 7
Repository-Manager: Replace __init__.py by ruamel.yaml #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…/ZMS into fb_conf_init_yaml
Products/zms/repositoryutil.py
Outdated
| vv['data'] = data | ||
| break | ||
| v.append((py.find('\t\t%s ='%kk), vv)) | ||
| v.append((filedata.find('\t\t%s ='%kk), vv)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmsdev: What is this find() intended for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be gone,,, Seems to have intended to include filedata.
…y/yaml Hint @zmsdev: the function readRepository still aggregates the data models form yaml/py not compatible (for py where does mappingproxy-type come from?)
|
@zmsdev Latest Issues1. at the first export linebreaks within a block create indent spaces that are shown as diff code. A second export normalizes this |
|
@zmsdev To avoid missing values it might be more safe to add any available to the output. I suppose this could be done more elegantly? |
|
ad [1]: |
|
@zmsdev
|
|
ad [2]: |
|
@drfho |
|
@zmsdev Screen: left = main, right=fb_conf_init_yaml_ruamel Screen: fb_conf_init_yaml_ruamel removes all false-attrs from the model If branch fb_conf_init_yaml_ruamel would not force to remove all attr-keys with a 0/false-value UX will be better. Its helpful to allow mentioning Tasks |
|
@zmsdev The main-branch creates; ,"keys":["##"
,"master = context.getPortalMaster()"
,"zmsclientids = []"
,"def getZMSPortalClients(zmsclient):"
," zmsclientids.append(zmsclient.getHome().id)"
," for zmsclientid in zmsclient.getPortalClients():"
," getZMSPortalClients(zmsclientid)"
," zmsclientids.sort()"
," return list(zmsclientids)"
,"return [(id,id) for id in getZMSPortalClients(zmsclient=master)]"]whereas this branch creates: ,"keys":"##\nmaster = context.getPortalMaster()\nzmsclientids = []\ndef getZMSPortalClients(zmsclient):\n zmsclientids.append(zmsclient.getHome().id)\n for zmsclientid in zmsclient.getPortalClients():\n getZMSPortalClients(zmsclientid)\n zmsclientids.sort()\n return list(zmsclientids)\nreturn [(id,id) for id in getZMSPortalClients(zmsclient=master)]"
|









Branch of #423 for evaluation of utilizing the ruamel.yaml-lib