feat(split): Increase split interval during idle#3182
Draft
carrefinho wants to merge 2 commits intozmkfirmware:mainfrom
Draft
feat(split): Increase split interval during idle#3182carrefinho wants to merge 2 commits intozmkfirmware:mainfrom
carrefinho wants to merge 2 commits intozmkfirmware:mainfrom
Conversation
850d839 to
224f033
Compare
Slows down BLE connection interval between split halves when keyboard goes idle, reducing central half battery consumption significantly during idle periods. When the keyboard becomes active again, connection parameters are restored to their normal values. There may be brief latency (0.6-1s) when waking from idle. Based on: zmkfirmware#682 Co-authored-by: Nick Winans <nick@winans.codes>
224f033 to
dcedcc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase BLE split connection interval when idle to significantly reduce central power consumption. There's a brief period (about 0.6-1s) where the chances of having misordered keypresses are higher when coming out of idle.
Based on #682, updated for current
mainand fixes issue of finding an extra invalid connection when trying to update.central_idle.clistener that increases connection interval when activity state changes to idleZMK_SPLIT_BLE_PREF_IDLE_*PR check-list