fix: changed shebang to make scripts more platform independent#45
Open
Tygo-van-den-Hurk wants to merge 1 commit intozmkfirmware:v3.5.0+zmk-fixesfrom
Open
fix: changed shebang to make scripts more platform independent#45Tygo-van-den-Hurk wants to merge 1 commit intozmkfirmware:v3.5.0+zmk-fixesfrom
Tygo-van-den-Hurk wants to merge 1 commit intozmkfirmware:v3.5.0+zmk-fixesfrom
Conversation
See for example this thread: https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash on why its better to use '#!/usr/bin/env bash' instead. Without this change these scripts will not run on some platforms. This is not a breaking change for the platforms it already works on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See for example this thread on why its better to use '#!/usr/bin/env bash' instead. Without this change these scripts will not run on some platforms. This is not a breaking change for the platforms it already works on.