boards: arm: Remove duplicate pro_mirco typo dir#29
Open
ulmanyar wants to merge 1 commit intozmkfirmware:v3.5.0+zmk-fixesfrom
Open
boards: arm: Remove duplicate pro_mirco typo dir#29ulmanyar wants to merge 1 commit intozmkfirmware:v3.5.0+zmk-fixesfrom
ulmanyar wants to merge 1 commit intozmkfirmware:v3.5.0+zmk-fixesfrom
Conversation
In the 3.5 branch the misspelled `sparkfun_pro_mirco_rp2040` seems to be an out-of-date duplicate of the `sparkfun_pro_micro_rp2040` with correct spelling. Signed-off-by: ulmanyar <ulmanyar@gmail.com>
|
I'm a bit confused by the duplicate PRs with this and #30 Shouldn't we just be removing since upstream now has it with the right name? |
Author
|
Yeah, patch #30 is to the v3.2 branch where it's not in upstream, so I guess it kind of makes sense? But then again 3.2 isn't used by ZMK any longer? So perhaps not really necessary. Regarding this patch, you're saying both the correctly spelled and the incorrectly spelled one can be removed since it's in upstream? But the pin assignment fixed in #28 isn't in 3.5 upstream? I opened a PR upstream on main, so I guess it needs to be cherry picked to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the 3.5 branch the misspelled
sparkfun_pro_mirco_rp2040seems to be an out-of-date duplicate of thesparkfun_pro_micro_rp2040with correct spelling.