drivers: display: ls0xx: add vcom toggle for extmode lo#14
Open
Nicell wants to merge 1 commit intozmkfirmware:v3.2.0+zmk-fixesfrom
Open
drivers: display: ls0xx: add vcom toggle for extmode lo#14Nicell wants to merge 1 commit intozmkfirmware:v3.2.0+zmk-fixesfrom
Nicell wants to merge 1 commit intozmkfirmware:v3.2.0+zmk-fixesfrom
Conversation
Adds support for toggling VCOM when not using extcom pins Signed-off-by: Nicholas Winans <nick@winans.io>
Member
Author
|
I've discovered a bug with this in use. Sometimes the blank command sent out by the VCOM toggle thread interrupts the transfer of an updated screen, so a semaphore should likely be implemented (per Pete). I think after using this that the VCOM toggle should be happening in the thread rather than in the send command function, as only one VCOM toggle per second is required, so no need to toggle it more often, which could result in higher power usage. The current system can also result in uneven time spent on low/high. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for toggling VCOM when not using extcom pins