Skip to content

Comments

Support Python 3.13#26

Open
fabasoad wants to merge 5 commits intozmbc:mainfrom
fabasoad:feat/py113
Open

Support Python 3.13#26
fabasoad wants to merge 5 commits intozmbc:mainfrom
fabasoad:feat/py113

Conversation

@fabasoad
Copy link

@fabasoad fabasoad commented Feb 7, 2025

Add support for Python 3.13

@zmbc
Copy link
Owner

zmbc commented May 8, 2025

Hi @fabasoad, thanks so much for the PR! It looks like there are two issues here:

  • This restricted shakespearelang to only be compatible with 3.13 (and above). I've corrected that in the pyproject.toml but it appears a new lockfile needs to be generated.
  • It appears shakespearelang isn't currently working with 3.13, with for example this test failure:
E             - Jumping to Scene II
E             + Jumping to Scene ('', '', 'II')
E             ?                  ++++++++++  ++
E             - ----------

Up for taking a look into these issues?

@fabasoad
Copy link
Author

Hi @zmbc! I've rebuilt lock file and pushed it to this branch. Re/ test failures - I looked at those failures this evening, but TBH proper fix for them requires internal project knowledge which I do not have at the moment unfortunately. If you have time to look at it then it would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants