Open
Conversation
… valid number, for consistency with other SPL implementations
Owner
|
Hi @sy-python! Thank you so much for your contribution. Overall this looks great. I have a few nitpicky questions about the intended behavior, which I'll ask in the relevant issues :) |
zmbc
reviewed
May 8, 2025
| assert exc.value.interpreter == s | ||
| s.state.character_by_name("Romeo").value = 42 | ||
| s.run_sentence("Listen to your heart!", "Juliet") | ||
| assert s.state.character_by_name("Romeo").value == 0 |
Owner
There was a problem hiding this comment.
This assert presumably needs to change to -2 to pass?
Owner
|
Yep, looks like it @sy-python -- could you update the tests? I'm happy to merge this without documentation, but do need the tests to pass. |
Author
|
Hello, sorry, was a bit busy with other things, will do this this week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #22.
Assumes #23 is an issues and fixes it.