-
Notifications
You must be signed in to change notification settings - Fork 351
RDP module #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
RDP module #644
Conversation
f6f4334 to
e0c9668
Compare
phillip-stephens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, really appreciate this effort to get this functionality added.
I haven't fully dug into this, but I'm wondering if there's a non-secure mode that can be used as well. I added a dockerized RDP service (TEST_MODULES=rdp make integration-test) on local port 3389 (username = username, pwd = password) which works through the Microsoft RDP app but not with the scanner. I tried just a simple toggle off of TLS but looks like something deeper is going on.
I can circle back to this as I get some free time, but I think this would be good to add support for since we may be most interested in such un-secured RDP services.
| } | ||
|
|
||
| type RDPResult struct { | ||
| OSVersion string `json:"os_version,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is the RDP Version based on testing a couple known public IPs
| OSVersion string `json:"os_version,omitempty"` | |
| RDPVersion string `json:"rdp_version,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually os_version.
Example:
10.0.17763 is:
https://learn.microsoft.com/en-us/windows/uwp/whats-new/windows-10-build-17763
Interesting, I'll try to poke at it this week too |
|
So, because I am using NTLM to get version information, this doesn't work for xrdp. |
Adds a module for RDP
At least a starting point for #17