new module DICOM

[RicYaben]

Adds a new module probe for the DICOM protocol, used in the healthcare sector to view and transfer patient records. The probe does not attempt to gather any further information than just the banner and follows the protocol latest standard. It issues an Association request, followed by an echo (kind of a heartbeat).

How to Test

Two methods, either test against a test service such as dicomserver.co.uk, or against a simple container serving an ORTHANC server. The parsers are tested locally.

Notes & Caveats

Some missing parts:

• Test in an Internet measurement: I am currently using it as a module in an older version of zgrab2, the current one is not stable enough. Using a retry iterator to upgrade the connection wrapped with TLS is very convenient but has failed me multiple times. I will check what is going on and update the probe.
• Add integration tests with docker container, ORTHANC server
• Missing zschemas

Issue Tracking

N/A

[phillip-stephens]

Hey @RicYaben thanks for the contribution!
I can take care of the ZSchema changes if you'll address those make lint issues! Looks like just a few things like not checking err values, etc.