Merged
Conversation
* yaml.el (yaml--parse-from-grammar): Hoist all the `(setq res` outside of the `pcase` and consolidate them.
Comparing symbols is much faster (pointer equality) than comparing strings, so use parse state symbols everywhere instead of their names. This requires changing the parse tree format for those nodes that have a "grammar-events-in/out": Instead of (STATE-NAME PARSE-STRING ...) we now use (PARSE-STRING STATE-SYMBOL ...) so that `(stringp (car tree))` can still be used to detect them. * yaml.el (yaml--tracing-ignore, yaml--grammar-resolution-rules) (yaml--grammar-events-in, yaml--grammar-events-out) (yaml--terminal-rules): Use symbols rather than strings for parser states. (yaml--state): Document the `state` slot's type as a symbol. (yaml--state-set-m): Fix docstring. (yaml--walk-events): Adjust to new parse-tree format. (yaml--set): Compare the symbols rather than their names. (yaml--parse-from-grammar): Use the state symbol where we used its name. Adjust the format of the returned parse tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.