feat: Implement forward-compatible ZKPassportRootVerifier design#120
Merged
feat: Implement forward-compatible ZKPassportRootVerifier design#120
Conversation
Contributor
michaelelliot
commented
Nov 4, 2025
michaelelliot
commented
- Added ZKPassportRootVerifier and ZKPassportSubVerifier contracts
- Added version to ProofVerificationParams enabling forward-compatible root verifier
- Improved contract layout to be more modular and easier to maintain
- Added common deployment logic to Utils.t.sol
- Refactored how fixtures are stored and loaded
- Added MockRootRegistry to avoid needing integration tests with zkpassport-packages
- Fixed all linter warnings
- Added ZKPassportRootVerifier and ZKPassportSubVerifier contracts - Added version to ProofVerificationParams enabling forward-compatible root verifier - Improved contract layout to be more modular and easier to maintain - Added common deployment logic to Utils.t.sol - Refactored how fixtures are stored and loaded - Added MockRootRegistry to avoid needing integration tests with zkpassport-packages - Fixed all linter warnings
michaelelliot
force-pushed
the
me/forward-compatible-root-verifier
branch
from
1b55928 to
7684f33
Compare
madztheo
reviewed
Nov 4, 2025
Contributor
madztheo
left a comment
madztheo
left a comment
There was a problem hiding this comment.
Everything looks good to me! Just two minor comments that need addressing
Maddiaa0
reviewed
Nov 5, 2025
- Introduced a config mapping - Implemented pause and unpause - Added more test coverage for root verifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.