fix: prevent genPublicFieldHash from mutating inputs #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ramGit22 wants to merge 1 commit into zkPassOfficial:master from ramGit22:feature

ramGit22 commented Oct 12, 2025

Motivation

Prevent unintended side effects when hashing public field data.

Linked Issue(s)

N/A

Solution

Map each public field entry to a shallow copy without the str property instead of deleting it in place.

Testing

npm run build

Safety & Compatibility

No API or behavioral changes; only removes unexpected mutation.
No dependency or config updates.
Type checks pass.

Reviewer Notes

Fix simply avoids mutating caller-provided data while preserving existing hashing logic.


          fix(helper): avoid mutating public field hash inputs

492e778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet