fix(imt): use index-based parent check for lastSubtrees in _update#63
Open
0x471 wants to merge 1 commit intozk-kit:mainfrom
Open
fix(imt): use index-based parent check for lastSubtrees in _update#630x471 wants to merge 1 commit intozk-kit:mainfrom
0x471 wants to merge 1 commit intozk-kit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
_updatein bothInternalBinaryIMTandInternalQuinaryIMTby replacing the value-based equality checks onlastSubtreeswith deterministic index-based parent comparison.Now we only update
lastSubtrees[i]when the update and last-insert paths share the same parent node at level i+1. Also moved the bounds check before the main loop to prevent a uint256 underflow panic on empty treesRelated Issue(s)
Closes #41
Checklist
yarn stylewithout getting any errors