doc: Document batch insertion error#75
Merged
vplasencia merged 3 commits intozk-kit:mainfrom Jun 10, 2025
Merged
Conversation
Contributor
Author
|
Just a minor documentation addition that shows an empty batch insert will error. |
vplasencia
approved these changes
Jun 9, 2025
Member
vplasencia
left a comment
There was a problem hiding this comment.
Thank you very much for this PR! 🚀
vplasencia
requested changes
Jun 9, 2025
Member
vplasencia
left a comment
There was a problem hiding this comment.
Hey @Ben-PH! Could you run make fmt to fix the formatting before we merge?
Contributor
Author
|
I added cmake and got a dprint error. I added dprint then got this error: I'm happy for this issue to be closed without merging. It's a trivial thing on its own, and there's a lot of other warnings missing IIRC. |
Closed
Member
|
Hey I just created an issue to fix this error: #80 |
vplasencia
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Other information
Checklist
yarn stylewithout getting any errorsImportant
We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical mistake, please feel free to message the team.