Open
Conversation
Added partial support for modifying the target directory in a cargo-like way. This allows the target directory to be set with either the `CABIN_TARGET_DIR` environment variable or with the `build.target-dir` configuration value in cabin.toml - with the configuration file taking priority. I plan to also support the `--target-dir` cli option, but that is not included in this commit.
zjwilliams
force-pushed
the
feat/configurable-target-directory
branch
from
9b7841e to
6299d12
Compare
This adds the '--target-dir' option to 'build', 'run', and 'test'. The effect is the same as setting 'CABIN_TARGET_DIR' or 'build.target-dir'; although the cli option will take precedence over the other two.
This addresses the errors generated by "lint" and "tidy", primarily removed the std::move() calls on const variables and converting Manifest::fromTargetDir() to use a braced initializer.
zjwilliams
force-pushed
the
feat/configurable-target-directory
branch
from
6299d12 to
596304a
Compare
This added tests for build, run, and test using --target-dir. This revealed a bug with test that is also fixed in this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone of cabinpkg#1266 for CI verification.