Skip to content

Windows no need to sync the folder when saving #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juanky201271 wants to merge 1 commit into from
Closed

Windows no need to sync the folder when saving #2198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions zingolib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ regtest = [ "zingo_common_components/for_test" ]

[dependencies]

rusqlite = { version = "0.37.0", features = ["bundled"] }

# Zingo
zingo-memo = { workspace = true }
zingo-status = { workspace = true }
Expand Down
10 changes: 7 additions & 3 deletions zingolib/src/lightclient/save.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,13 @@ fn write_to_path(wallet_path: &std::path::Path, bytes: &[u8]) -> std::io::Result
let file = writer.into_inner().map_err(|e| e.into_error())?;
file.sync_all()?;
std::fs::rename(&temp_wallet_path, wallet_path)?;
if let Some(parent) = wallet_path.parent() {
let wallet_dir = std::fs::File::open(parent)?;
let _ignore_error = wallet_dir.sync_all(); // NOTE: error is ignored as syncing dirs on windows OS may return an error
// NOTE: in windows no need to sync the folder, only for linux & macOS.
#[cfg(unix)]
{
if let Some(parent) = wallet_path.parent() {
let wallet_dir = std::fs::File::open(parent)?;
let _ignore_error = wallet_dir.sync_all();
}
}

Ok(())
Expand Down