Skip to content

Comments

chore: add tests for zingo-netutils & fixes#28

Merged
zancas merged 3 commits intodevfrom
fix/zingo-netutils-tests
Feb 23, 2026
Merged

chore: add tests for zingo-netutils & fixes#28
zancas merged 3 commits intodevfrom
fix/zingo-netutils-tests

Conversation

@dorianvp
Copy link
Member

@dorianvp dorianvp commented Feb 12, 2026

This PR fixes the following issues:

  • Scheme handling being too permissive. It allowed schemes other than HTTP, like FTP.
  • gRPC could silently downgrade to HTTP/1.1 over TLS, meaning it could seem connected, but fail at the gRPC layer. Note that gRPC does not work over HTTP/1.1.
  • Refactors the test-only TLS certificate.

@dorianvp dorianvp self-assigned this Feb 13, 2026
@dorianvp dorianvp force-pushed the fix/zingo-netutils-tests branch from 07ca287 to e8a1b2b Compare February 15, 2026 20:32
@dorianvp dorianvp changed the title chore: add tests for zingo-netutils chore: add tests for zingo-netutils & fixes Feb 17, 2026
@dorianvp dorianvp marked this pull request as ready for review February 17, 2026 17:35
@zancas
Copy link
Member

zancas commented Feb 20, 2026

Conflicts!

@zancas zancas assigned zancas and unassigned zancas and dorianvp Feb 23, 2026
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a cargo update got rolled into this PR. I wonder about the tradeoffs of preferring cargo updates to go into their own PRs?

@zancas zancas merged commit 99b661e into dev Feb 23, 2026
8 checks passed
@dorianvp dorianvp deleted the fix/zingo-netutils-tests branch February 23, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants