Open
Conversation
Contributor
Author
|
NOTE: If we release zaino before this PR lands it should be updated so that the database updates go into the v1.1.0->v1.2.0 migration (instead of the v1.0.0->1.1.0 migration currently on dev). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
#787 updated the height field of the BlockIndex struct but did not implement this change as a V2 serialisation schema.
This PR brings this change into line with the database versioning strategy by:
NOTE:
Because BlockHeaderData is stored in a [
StoredEntryVar], and the headers lmdb table does not use fixed length optimisations, it is possible for us to just provide the new serde implementation.Where the new chain index database has been partially built before this update, the headers table will hold a mix of V1 and V2 BlockHeaderData structs'.
Where update to chainindex has not yet taken place, or where the database will be built fresh, V2 BlockHeaderData serde will be used.