Draft
Conversation
zancas
reviewed
Nov 6, 2025
zancas
reviewed
Nov 6, 2025
nachog00
reviewed
Nov 11, 2025
| map_err::Mapper: map_err::MapRpcError<MethodError>, | ||
| { | ||
| let id = self.id_counter.fetch_add(1, Ordering::SeqCst); | ||
| #[derive(Deserialize)] |
Contributor
There was a problem hiding this comment.
Is it intentional for this to be defined within the send_request method?
Contributor
There was a problem hiding this comment.
i see, it's generic over R
nachog00
reviewed
Nov 11, 2025
|
|
||
| let max_attempts = 5; | ||
| let mut attempts = 0; | ||
| loop { |
Contributor
There was a problem hiding this comment.
It seems like these changes are dropping the retry feature. Is it intentional?
| T: std::fmt::Debug + Serialize, | ||
| R: std::fmt::Debug + for<'de> Deserialize<'de> + ResponseToError, | ||
| >( | ||
| async fn send_request<T, R, MethodError>( |
Contributor
There was a problem hiding this comment.
This method is looking large enough that i would recommend chopping it down into smaller functions, to keep it readable and testable.
| code = err.code, | ||
| kind = ?err.kind(), | ||
| message = %err.message, | ||
| params = tracing::field::debug(¶ms), |
Contributor
There was a problem hiding this comment.
Are we clear on the sensitivity of these values? can we freely log them in any case?
nachog00
reviewed
Nov 11, 2025
| /// Json RPSee Error type. | ||
| #[derive(Serialize, Deserialize, Debug)] | ||
| #[derive(Serialize, Deserialize, Debug, Clone)] | ||
| pub struct RpcError { |
Contributor
There was a problem hiding this comment.
I would put all these error types on jsonrpsee/connector.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
Tests
Specifications & References
Follow-up Work
PR Checklist