Closed
Conversation
This was referenced Oct 10, 2025
Closed
Contributor
Author
|
Current status: FetchService has been updated to use the ChainIndex instead of the LocalCache. StateService still uses LocalCache. There are currently several test failures and hangs due to this switchover highlighting possible bugs in the new ChainIndex module. |
| /// changes (a new block is mined or a reorg occurs). | ||
| /// | ||
| /// If the chain tip has changed from the given spanshot returns None. | ||
| /// If a snapshot is given and the chain tip has changed from the given spanshot, returns None. |
| /// changes (a new block is mined or a reorg occurs). | ||
| /// | ||
| /// Returns None if the chain tip has changed from the given snapshot. | ||
| /// If a snapshot is given and the chain tip has changed from the given spanshot, returns None. |
| FinalisedStateError::JsonRpcConnectorError(transport_error) | ||
| } | ||
| RpcRequestError::JsonRpc(error) => { | ||
| FinalisedStateError::Custom(format!("argument failed to serialze: {error}")) |
| } | ||
| RpcRequestError::JsonRpc(error) => { | ||
| FinalisedStateError::Custom(format!("argument failed to serialze: {error}")) | ||
| NonFinalisedStateError::Custom(format!("argument failed to serialze: {error}")) |
| MempoolError::JsonRpcConnectorError(transport_error) | ||
| } | ||
| RpcRequestError::JsonRpc(error) => { | ||
| MempoolError::Critical(format!("argument failed to serialze: {error}")) |
| } | ||
| RpcRequestError::JsonRpc(error) => { | ||
| MempoolError::Critical(format!("argument failed to serialze: {error}")) | ||
| FetchServiceError::Critical(format!("argument failed to serialze: {error}")) |
| .ok() | ||
| } | ||
|
|
||
| /// Strips the ouputs and from all transactions, retains only |
| } | ||
|
|
||
| /// Strips the ouputs and from all transactions, retains only | ||
| /// the nullifier from all orcard actions, and clears the chain |
| let mempool = Mempool::spawn(mempool_source, None).await.map_err(|e| { | ||
| FetchServiceError::BlockCacheError(BlockCacheError::Custom(e.to_string())) | ||
| })?; | ||
| .unwrap(); |
| @@ -170,10 +160,8 @@ impl Drop for FetchService { | |||
| pub struct FetchServiceSubscriber { | |||
Contributor
There was a problem hiding this comment.
doc comment for this struct seems incomplete
This was referenced Oct 30, 2025
Contributor
|
closed for #650 |
github-project-automation
bot
moved this from In progress
to Done
in Zaino, The Zallet Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates StateService and FetchService to use ChainIndex, removes old local cache code.
Motivation
replaces Zainod chain index #496
closes Update Zainod to use ChainIndex and remove legacy local cache code from codebase. #528
built atop Ready tests for ChainIndex #597
Solution
Tests
Specifications & References
Follow-up Work
PR Checklist