Add cutoffs parameter to AllowedStructuresFilter, log_file to ASEGeoOpt #444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue where the AllowedStructuresFilter was filtering out molecules that were within the default ASE covalent radii, but upon inspection of the structures it had really not formed these molecules. Adding a cutoffs keyword to the node should hopefully help. Now you can pass a dictionary to it, like
cutoffs = {"C": 1, "H": 0.5}sets the cutoff radii of all C atoms to 1 Angstrom and of all H atoms to 0.5 Angstrom. This will result in a more sparsely connected graph.I got a bit annoyed that ASEGeoOpt was printing the log output, so I added a keyword argument that defaults to
opt.log, similar to how molecular dynamics logs default tomd.log.