Skip to content

Conversation

@TobiasDijkhuis
Copy link
Contributor

Fixes #387, adds more arguments such as the charge and multiplicity to the TBLite off-graph model, and removes any duplicates from the AllowedStructuresFilter node by using a set instead of a list.

@PythonFZ
Copy link
Member

Thanks @TobiasDijkhuis for this contribution. Looks good to me! Relying on auto seems more reasonable than having the logic for computing the bins hard coded and having the option to include the number of bins is nice.

LGTM 🎉

@PythonFZ PythonFZ enabled auto-merge (squash) December 16, 2025 17:17
@PythonFZ
Copy link
Member

Can you look into tests/integration/configuration_selection/test_index.py::test_index_chained before merging.

>       assert histogram.labels_df.to_dict()["bin_edges"][0] == pytest.approx(
            0.0952380952380952
        )
E       assert 0.0317460317460317 == 0.0952380952380952 ± 9.5e-08

@PythonFZ PythonFZ disabled auto-merge December 16, 2025 17:31
@TobiasDijkhuis
Copy link
Contributor Author

Hi @PythonFZ, this test assumed 1 bin before (because ceil(len(labels) / 100) = 1, but now it gets 3. The last (third) edge is correct still. I have corrected the test to take this into account.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@PythonFZ PythonFZ enabled auto-merge (squash) December 16, 2025 18:40
Copy link
Member

@PythonFZ PythonFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PythonFZ PythonFZ merged commit 3af81bf into zincware:main Dec 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try different method to calculate bin amount in LabelHistogram

3 participants