More generic configuration filter #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…zincware/IPSuite into more-generic-strucktures-filter
for more information, see https://pre-commit.ci
test fix
…zincware/IPSuite into more-generic-strucktures-filter
for more information, see https://pre-commit.ci
…zincware/IPSuite into more-generic-strucktures-filter
for more information, see https://pre-commit.ci
PythonFZ
reviewed
Apr 18, 2024
PythonFZ
reviewed
Apr 18, 2024
PythonFZ
reviewed
Apr 18, 2024
Comment on lines
63
to
64
| values = [ | ||
| np.max(np.linalg.norm(value, axis=1), axis=0) for value in values |
for more information, see https://pre-commit.ci
Contributor
Author
|
Don't know why the test fail here, locally they pass. Do you have an idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a an overhauled version of the configuration filter node and adds test for it.
It is possible now to filter max values or around the mean value in multiples of the std. Moreover it become easier to extend to include other cutoffs.
Solves issue #182